Hi Caleb,
On Thu, 4 Jul 2024 at 16:02, Caleb Connolly caleb.connolly@linaro.org wrote:
Hi Simon,
On 04/07/2024 09:48, Simon Glass wrote:
Now that sandbox is using cyclic for video, it trips the 1us time limit. Updating the sandbox display often takes 20ms or more.
Increase the limit to 100ms to avoid a warning.
Signed-off-by: Simon Glass sjg@chromium.org
(no changes since v1)
common/Kconfig | 1 + 1 file changed, 1 insertion(+)
diff --git a/common/Kconfig b/common/Kconfig index 87b0ec3ea8f..83c81edac20 100644 --- a/common/Kconfig +++ b/common/Kconfig @@ -636,6 +636,7 @@ config SPL_CYCLIC
config CYCLIC_MAX_CPU_TIME_US int "Sets the max allowed time for a cyclic function in us"
default 100000 if SANDBOX # sandbox video is quite slowWon't this be the case for other boards as well? Maybe it would make sense to bump this unconditionally or adjust the cyclic API so users could provide a hint about how long they'll take to run.
Isn't 100ms a bit excessive just to flush a buffer?
I have not noticed this problem on the few boards I have tested with, i.e. sandbox seems to be unique.
sandbox does seem to take quite a while...it is updating the display using SDL. You can try it out on your machine if you like, and see what happens.
default 5000 help The max allowed time for a cyclic function in us. If a functions-- // Caleb (they/them)
Regards, Simon