Re: [U-Boot] [PATCH v4 1/3] ARM: Tegra: FDT: Add USB EHCI function for T30/T114

On 06/20/2013 02:13 AM, Jim Lin wrote:

Add DT node for USB EHCI function. Add support for T30-Cardhu, T30-Beaver, T114-Dalmore boards.

diff --git a/arch/arm/dts/tegra114.dtsi b/arch/arm/dts/tegra114.dtsi

• usb@7d004000 {

• compatible = "nvidia,tegra114-ehci";
  

• reg = <0x7d004000 0x4000>;
  

• interrupts = <53>;
  

• phy_type = "utmi";
  

If Tegra114 and Tegra30 are anything like Tegra20, then USB2 doesn't support UTMI mode; it's either ULPI or HSIC. Can you please check this.

The same comment applies in tegra30.dtsi.

diff --git a/include/fdtdec.h b/include/fdtdec.h

diff --git a/lib/fdtdec.c b/lib/fdtdec.c

As I said before, driver changes should be in a separate patch to DT changes. Please move the changes to fdtdec.* into patch 2/3.