On 11/18/18 4:16 PM, Simon Glass wrote:
This is an experimental check for adding new uclasses without a test.
I am not sure of the best way to add U-Boot-specific tests, although in this case, it would not fire on Linux.
Signed-off-by: Simon Glass sjg@chromium.org
scripts/checkpatch.pl | 7 +++++++ 1 file changed, 7 insertions(+)
diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl index 373094e59ef..2f9edb429d5 100755 --- a/scripts/checkpatch.pl +++ b/scripts/checkpatch.pl @@ -3033,6 +3033,13 @@ sub process { "adding a line without newline at end of file\n" . $herecurr); }
# ask for a test if a new uclass ID is addedif ($realfile =~ /uclass-id.h/ && $line =~ /^\+/) {WARN("NEW_UCLASS","Possible new uclass - make sure to add a test in test/dm/<name>.c\n" . $herecurr);}# check we are in a valid source file C or perl if not then ignore this hunk next if ($realfile !~ /.(h|c|pl|dtsi|dts)$/);
I would prefer if this script were a verbatim copy of the Linux upstream. Joe Perches is continually working on it. So let's update to 4.20 instead.
Tests are needed for any new functionality. Nothing special about u-classes here. The reviewer/custodian should take care that this is observed.
Best regards
Heinrich