Hello Michael
-----Original Message----- From: Michael Walle michael@walle.cc Sent: Monday, November 8, 2021 2:29 PM To: ZHIZHIKIN Andrey andrey.zhizhikin@leica-geosystems.com Cc: Gaurav Jain gaurav.jain@nxp.com; Adam Ford aford173@gmail.com; U-Boot Mailing List u-boot@lists.denx.de; Stefano Babic sbabic@denx.de; Fabio Estevam festevam@gmail.com; Peng Fan peng.fan@nxp.com; Simon Glass sjg@chromium.org; Priyanka Jain priyanka.jain@nxp.com; Ye Li ye.li@nxp.com; Horia Geanta horia.geanta@nxp.com; Ji Luo ji.luo@nxp.com; Franck Lenormand franck.lenormand@nxp.com; Silvano Di Ninno silvano.dininno@nxp.com; Sahil Malhotra sahil.malhotra@nxp.com; Pankaj Gupta pankaj.gupta@nxp.com; Varun Sethi V.Sethi@nxp.com; dl- uboot-imx uboot-imx@nxp.com; Shengzhou Liu shengzhou.liu@nxp.com; Mingkai Hu mingkai.hu@nxp.com; Rajesh Bhagat rajesh.bhagat@nxp.com; Meenakshi Aggarwal meenakshi.aggarwal@nxp.com; Wasim Khan wasim.khan@nxp.com; Alison Wang alison.wang@nxp.com; Pramod Kumar pramod.kumar_1@nxp.com; Andy Tang andy.tang@nxp.com; Adrian Alonso adrian.alonso@nxp.com; Vladimir Oltean olteanv@gmail.com Subject: Re: [EXT] Re: [PATCH v4 03/16] i.MX8M: crypto: updated device tree for supporting DM in SPL
Caution: EXT Email
Am 2021-11-08 09:48, schrieb ZHIZHIKIN Andrey: ..
Disabling the JR0 node in the kernel makes this error go away, and decreases the JR count to 2 which can be observed in the NXP vendor kernel.
I suggest you to extract the node disabling from this patch and send it to
Kernel.
Once accepted in upstream - this change would be picked up by the U-Boot at next DTB re-sync.
No. Please don't disable the node in the kernel device tree. IMHO TF-A (or whoever is using the job ring) is optional. So either u-boot should disable it, either statically by -u-boot.dtsi (but please _per_ board) or at runtime by fixing up the device tree. Another way would be for linux to skip probing if its not available. Though I don't know whether this is "the ususal way".
But as Andrey mentioned, any job ring could be taken away. So the -u-boot.dtsi method doesn't seem to be that good.
Moved the JR0 disabled code to *-u-boot.dtsi files in version 5 of this patch series.
Regards Gaurav Jain
-michael