Hi Wolfgang,
even though I like the weak stuff, I agree with you. I also like Stefan's idea about removing the #ifdef from the code.
So I will update my patch in this direction.
The main idea behind my patch is to fix the bootloader autoprotection for 4xx. Do you (sr, J., others) think i is also a good idea to add this:
/* Monitor protection ON by default */ #if (CFG_MONITOR_BASE >= CFG_FLASH_BASE) flash_protect (FLAG_PROTECT_SET, CFG_MONITOR_BASE, +#if defined(CONFIG_4xx) 0xffffffff, +#else CFG_MONITOR_BASE + monitor_flash_len - 1, +#endif flash_get_info(CFG_MONITOR_BASE)); #endif
To be honest, I hope to get my autoprotection patch into 1.3.3 (as a bug fix). But the above three lines would be satisfactory for fixing the issue. Finally I would like to have both changes applied.
Matthias
On Sunday 20 April 2008 03:14:10 Wolfgang Denk wrote:
In message 20080418160157.GB12486@game.jcrosoft.org you wrote:
+#if defined(CFG_FLASH_AUTOPROTECT_LIST)
- struct apl_s {
ulong start;ulong size;- } apl[] = CFG_FLASH_AUTOPROTECT_LIST;
+#endif
I think it will be better to create a weak structure.
In the interest of memory footprint I prefer to stick with the #ifdef here.
Best regards,
Wolfgang Denk