Re: [U-Boot] [PATCH] dm: simplify uclass_foreach_dev() implementation

On 10 August 2015 at 10:09, Masahiro Yamada yamada.masahiro@socionext.com wrote:

This can be simply written with list_for_each_entry(), maybe this macro was not necessary in the first place.

Signed-off-by: Masahiro Yamada yamada.masahiro@socionext.com

include/dm/uclass.h | 9 ++------- 1 file changed, 2 insertions(+), 7 deletions(-)

Acked-by: Simon Glass sjg@chromium.org

diff --git a/include/dm/uclass.h b/include/dm/uclass.h index d56877c..d214b88 100644 --- a/include/dm/uclass.h +++ b/include/dm/uclass.h @@ -240,12 +240,7 @@ int uclass_resolve_seq(struct udevice *dev);

• are no more devices.
• @uc: uclass to scan

*/ -#define uclass_foreach_dev(pos, uc) \

•   for (pos = list_entry((&(uc)->dev_head)->next, typeof(*pos),    \
  

•                   uclass_node);                                   \
  

•        prefetch(pos->uclass_node.next),                           \
  

•                   &pos->uclass_node != (&(uc)->dev_head);         \
  

•        pos = list_entry(pos->uclass_node.next, typeof(*pos),      \
  

•                   uclass_node))
  

+#define uclass_foreach_dev(pos, uc) \

•   list_for_each_entry(pos, &uc->dev_head, uclass_node)
  
  

#endif

1.9.1