28 Apr
2008
28 Apr
'08
11:07 a.m.
In message Pine.LNX.4.64.0804280223420.4305@blarg.am.freescale.net you wrote:
- adjust __spin_table alignment to match ePAPR v0.94 spec
- loop over all cpus when determing who is up. This fixes an issue if the "boot cpu" isn't core0. The "boot cpu" will already be in the cpu_up_mask so there is no harm
- Added some protection in the code to ensure proper behavior. These changes are explicitly needed but don't hurt:
- Added eieio to ensure the "hot word" of the table is written after all other table updates have occurred.
- Added isync to ensure we don't prefetch loading of table entries until we a released
These issues we raised by Dave Liu.
Signed-off-by: Kumar Gala galak@kernel.crashing.org
Will Andy send a pull request or shall I apply directly?
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd@denx.de
The management question ... is not _whether_ to build a pilot system
and throw it away. You _will_ do that. The only question is whether
to plan in advance to build a throwaway, or to promise to deliver the
throwaway to customers. - Fred Brooks, "The Mythical Man Month"