-----Original Message----- From: Marek Vasut marex@denx.de Sent: Tuesday, March 3, 2020 8:13 PM To: Ley Foon Tan lftan.linux@gmail.com Cc: Tan, Ley Foon ley.foon.tan@intel.com; u-boot@lists.denx.de; Simon Goldschmidt simon.k.r.goldschmidt@gmail.com; See, Chin Liang chin.liang.see@intel.com; Chee, Tien Fong tien.fong.chee@intel.com Subject: Re: [PATCH] arm: socfpga: arria10: Add save_boot_params()
On 3/3/20 10:14 AM, Ley Foon Tan wrote:
On Mon, Mar 2, 2020 at 6:40 PM Marek Vasut marex@denx.de wrote:
On 3/2/20 8:20 AM, Tan, Ley Foon wrote: Hi,
[...]
On 2/26/20 8:01 PM, Ley Foon Tan wrote: [...]
+#define BOOTROM_SHARED_MEM_ADDR
(CONFIG_SYS_INIT_RAM_ADDR + 0x40000 \
- 0x800) #define+RST_STATUS_SHARED_ADDR
(BOOTROM_SHARED_MEM_ADDR + 0x438)Are all these magic values needed or is there some more descriptive macro name available for them ?
0x40000 is onchip ram size and 0x800 is 2KB size. I can convert these to 2 macos.
Aren't those already defined in include/configs/socfpga_common.h ?
socfpga_common.h have this: #define CONFIG_SYS_INIT_RAM_SIZE (0x40000 -
CONFIG_SYS_SPL_MALLOC_SIZE)
But, we can't use it here.
Why ?
CONFIG_SYS_INIT_RAM_SIZE is minus with CONFIG_SYS_SPL_MALLOC_SIZE, not 256KB (0x40000).
Regards Ley Foon