Re: [U-Boot-Users] [PATCH] Remove code duplication for setting the default environment

In message 20080706170626.GH20299@prithivi.gnumonks.org you wrote:

+void default_env(void) +{

• if (sizeof(default_environment) > ENV_SIZE)
• {

• puts ("*** Error - default environment is too large\n\n");
  

• return;
  

• }

Incorrect brace style.

• memset (env_ptr, 0, sizeof(env_t));
• memcpy (env_ptr->data,

• default_environment,
  

• sizeof(default_environment));
  

Put on one line ?

--- u-boot.orig/common/env_common.c +++ u-boot/common/env_common.c

...

• if (sizeof(default_environment) > ENV_SIZE)
  

...

--- u-boot.orig/common/env_nand.c +++ u-boot/common/env_nand.c

...

• if (default_environment_size > CFG_ENV_SIZE){

Looks like a sleeping bug to me...

+void default_env(void);

Please name "set_default_env()".

Best regards,

Wolfgang Denk