Re: [U-Boot] [PATCH v3 2/3] lib: uuid: add functions to generate UUID version 4

Dear Przemyslaw Marczak,

In message bf85640549b0798b838145e9bad6dcc59454e7ae.1394807506.git.p.marczak@samsung.com you wrote:

This patch adds support to generate UUID (Universally Unique Identifier) in version 4 based on RFC4122, which is randomly.

Source: https://www.ietf.org/rfc/rfc4122.txt

...

+#define UUID_BIN_LEN 16

...

+struct uuid {

• unsigned int time_low;
• unsigned short time_mid;
• unsigned short time_hi_and_version;
• unsigned char clock_seq_hi_and_reserved;
• unsigned char clock_seq_low;
• unsigned char node[6];

+} __packed;

Maybe we should define UUID_BIN_LEN as sizeof(struct uuid) ?

Best regards,

Wolfgang Denk