On Wednesday 07 March 2012 08:21:08 Stefan Roese wrote:
On Wednesday 07 March 2012 13:03:52 Amit Virdi wrote:
From: Vipin KUMAR vipin.kumar@st.com
ethaddr can be optionally read from i2c memory. So, chip_config command supports reading/writing hw mac id into i2c memory. Placing this code within CONFIG_CMD_NET as this would only be needed when network interface is configured
Signed-off-by: Vipin Kumar vipin.kumar@st.com Signed-off-by: Amit Virdi amit.virdi@st.com
I'm not really sure, why you have this special ethaddr handling in I2C prom here at all. Isn't it enough to have the MAC address (ethaddr) stored in the U-Boot environment (NOR, NAND, etc)? Why do you need this additional I2C stuff? Could you please explain this?
if the board is coming from the factory manufactured like this, then it makes sense to me to support it. after all, development boards aren't sold as "only runs u-boot". if i got a dev board and installed u-boot on it myself, i'd really prefer it to automatically look up the mac if it's stored locally.
that said, this looks like a debug command, so not sure if i would even bother making it depend on CONFIG_CMD_NET if there's no real runtime overhead ... -mike