Dear Wolfgang Denk,
Isn't that great?
Sure!!! :)
What happens when we return here? Obviously this function is supposed to never return. Should we call hang() here?
Given that z_error is invoked by Assert macro (never used) and that "exit" function (other than closing all opened stream) will terminate program execution, I suggest to remove it without adding others instructions letting u-boot to hang by itself (if it will do this).
What's your idea? Thanks, Giuseppe
-----Original Message----- From: Wolfgang Denk [mailto:wd@denx.de] Sent: Thursday, September 03, 2009 10:26 AM To: Giuseppe CONDORELLI Cc: u-boot@lists.denx.de Subject: Re: [U-Boot] [PATCH v2] zlib: fix code when DEBUG is defined
Dear Giuseppe CONDORELLI,
In message 1251970209-9053-1-git-send-email-giuseppe.condorelli@st.com you wrote:
Removed stdio.h inclusion and moved trace macros to use printf avoiding to write debug informations to standard error.
Signed-off-by: Giuseppe Condorelli giuseppe.condorelli@st.com
lib_generic/zlib.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-)
old: 1 files changed, 29 insertions(+), 30 deletions(-) new: 1 files changed, 2 insertions(+), 2 deletions(-)
Isn't that great?
@@ -2000,7 +2001,6 @@ void z_error (m) char *m; { fprintf(stderr, "%s\n", m);
- exit(1);
} #endif
Sorry for not catching this in the first round.
What happens when we return here? Obviously this function is supposed to never return. Should we call hang() here?
Best regards,
Wolfgang Denk