On Tue, Jul 5, 2022 at 11:57 AM Daniel Thompson daniel.thompson@linaro.org wrote:
On Tue, Jul 05, 2022 at 11:05:04AM +0530, Sumit Garg wrote:
Hi Daniel,
Thanks for your review.
On Mon, 4 Jul 2022 at 21:28, Daniel Thompson daniel.thompson@linaro.org wrote:
On Mon, Jul 04, 2022 at 06:28:38PM +0530, Sumit Garg wrote:
U-boot specific DT properties belong to *-uboot.dtsi
... and are already included in starqltechn-uboot.dtsi (which is the only current consumer of sdm845.dtsi).
Adding fuller comments, such as the above, makes things much easier to review: it makes clear why you consider the properties redundant rather then misfiled.
I would rather say that this change is to follow the u-boot DT recommendation [1]. I will update the commit message accordingly. BTW, it looks like u-boot DT properties are incorrectly specified in starqltechn-uboot.dtsi here [2] as there aren't any subnodes for the "gcc" node. I will correct that too.
That's fine. The wording was just an example and we written before I reviewed patch 4 and spotted the inconsistancies there.
Daniel.
Reviewed-by: Ramon Fried rfried.dev@gmail.com