Hi Lukasz,
On Tue, 17 Sep 2019 at 15:06, Lukasz Majewski lukma@denx.de wrote:
On Tue, 17 Sep 2019 14:19:33 -0500 Adam Ford aford173@gmail.com wrote:
On Tue, Sep 17, 2019 at 1:34 PM Simon Glass sjg@chromium.org wrote:
Hi Lukasz,
On Tue, 17 Sep 2019 at 00:22, Lukasz Majewski lukma@denx.de wrote:
Hi Simon,
On Sun, 18 Aug 2019 at 19:30, Peng Fan peng.fan@nxp.com wrote:
> Subject: [PATCH v2 8/9] spl: Introduce SPL_DM_GPIO Kconfig > define > > This define indicates if DM_GPIO shall be supported in SPL. > This allows proper operation of DM converted GPIO drivers > in SPL, which use #if !CONFIG_IS_ENABLED(DM_GPIO) to also > support not yet DM/DTS converted boards. >
Many of the drivers list the SPL_DM options under their respective heading. For example, SPL_DM_USB is under the USB menu right next to the option to select CONFIG_DM_USB. If we're going to add the option to separate DM_GPIO from SPL_DM_GPIO, I would suggest following that pattern and place it in the GPIO menu so they are next to each other and make the dependency obvious.
For the current patch I've followed the pattern and added SPL_DM_GPIO to the "spl" submenu of menuconfig.
And as I've written in the other mail - I think that SPL_DM_GPIO shall depend on DM_GPIO.
Considering the above - shall I place SPL_DM_GPIO next to DM_GPIO section or to the "spl" submenu?
That makes sense to me. At some point we should change them all.
+Tom Rini for comment too
Regards, Simon