Re: [U-Boot] [PATCH v3 03/11] drivers: spi: cf_spi: convert to driver model

On 13 October 2018 at 16:34, Angelo Dureghello angelo@sysam.it wrote:

Converting to driver model and removes non-dm code.

Signed-off-by: Angelo Dureghello angelo@sysam.it

Changes for v2:

• removed non DM code part
• add default setup of CTAR registers
• add DT CTAR register setup support

Changes for v3:

• changed commit head
• removed spi_slave reference
• add #ifdefs for the case OF_PLATDATA is used

---

drivers/spi/cf_spi.c | 517 +++++++++++++++--------- include/dm/platform_data/spi_coldfire.h | 29 ++ 2 files changed, 352 insertions(+), 194 deletions(-) create mode 100644 include/dm/platform_data/spi_coldfire.h

This is a big tricky to review, but it looks right to me.

Reviewed-by: Simon Glass sjg@chromium.org