Hi Wolfgang
On 06/02/2010 14:26, Wolfgang Denk wrote:
Dear "kevin.morfitt@fearnside-systems.co.uk",
In message4B6D687F.2060606@fearnside-systems.co.uk you wrote:
The patches are split so that each patch makes only one type of change, so there's only one thing that needs to be checked in each patch.
- patches 1 and 2 only make white-space changes (the change was too big
so I had to split it into 2 patches)
I think this should be merged into a single patch.
OK. It'll be about 140K though so I'llput it on a web site.
- patch 3 only makes code style changes such as moving external
function prototypes to header files, removing unused code, making line lengths less than 81 characters, brackets around if/then/else/when/do blocks, generally anything that checkpatch.pl warns about
- patch 4 changes the s3c24x0 register struct members to lower case
(which is the main aim of the patches)
I can modify the patches to do all changes at the same time but when I've done this before I've always been told that each patch should have only one type of change in it, and I'm not sure if it would get NACK'ed by someone else.
Correct. Please keep the split as is.
What do you think - do you still want me to change the patch series?
No, please leave as is.
OK, it's quite old now though so I might need to rebase it to the current master.
Regards Kevin
Best regards,
Wolfgang Denk