16 Feb
2009
16 Feb
'09
10:10 p.m.
Dear ksi@koi8.net,
In message Pine.LNX.4.64ksi.0902131156250.26866@home-gw.koi8.net you wrote:
Can you please send your patches with some better commit messages. You only send your Signed-off-by, without any explanation. Please change this.
There is not much sense in extensive commit messages in this case, IMHO. It is not a bug fix or added feature at one particular place; it is a major rework. The only message I can give is something like "Changes for multiadapter/multibus I2C support..."
This sounds very much as if there was a danger that the patches are not logically cut - did you make sure that eahc of the commits is still bisectable?
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd@denx.de
"A verbal contract isn't worth the paper it's printed on."
- Samuel Goldwyn