On Sat, Mar 19, 2016 at 06:25:48PM -0600, Simon Glass wrote:
Hi Tom,
On 15 March 2016 at 21:32, Simon Glass sjg@chromium.org wrote:
On 15 March 2016 at 11:20, Tom Rini trini@konsulko.com wrote:
good enough.
- Make <asm/io.h> include <asm/types.h> like other arches do
- Enable many many more drivers in sandbox_defconfig so that we can get more build-time testing on this platform.
Cc: Simon Glass sjg@chromium.org Signed-off-by: Tom Rini trini@konsulko.com
arch/sandbox/include/asm/cache.h | 1 + arch/sandbox/include/asm/io.h | 1 + configs/sandbox_defconfig | 56 ++++++++++++++++++++++++++++++++++++-- 3 files changed, 56 insertions(+), 2 deletions(-)
Great!
Reviewed-by: Simon Glass sjg@chromium.org
I am seeing errors with this patch building for sandbox:
tools/bin2header.c: In function ‘main’: tools/bin2header.c:26:3: warning: implicit declaration of function ‘read’ [-Wimplicit-function-declaration] nread = read(0, buf, sizeof(buf)); ^ cmd/license.c:15:21: fatal error: license.h: No such file or directory #include <license.h> ^ compilation terminated. make[2]: *** [cmd/license.o] Error 1 make[2]: *** Waiting for unfinished jobs.... make[1]: *** [cmd] Error 2 make[1]: *** Waiting for unfinished jobs.... make: *** [sub-make] Error 2
Can you take a look? If it matters I am doing an out-of-tree build.
Yeah, sorry, this relies on the cmd: license patch I posted in order to work as nothing uses the license command today and it's pretty badly broken, but easily fixed. I was hoping Masahiro would chime in on the kbuild fun that the patch does, but if you wanna pull it in that's fine, I'll probably grab it soon otherwise myself.