Am 13.04.2016 um 19:58 schrieb Stephen Warren:
On 04/13/2016 11:42 AM, Andreas Färber wrote:
Am 13.04.2016 um 19:00 schrieb Stephen Warren:
Anyway, nothing in your benefits-of-EFI statement implies that relying on $fdtfile being set is correct. That's a new requirement that didn't exist before. Either the requirement needs to be removed (e.g. using a default FDT filename such as "${soc}-${board}${boardver}.dts") or only enabling this functionality on boards that do set $fdtfile, since it relies on that.
$fdtfile needs to be the Linux filename. It does not always follow the same pattern as the U-Boot variables you suggest here. CONFIG_DEFAULT_DEVICE_TREE ".dtb" might work better, and that was my question to you.
That pattern is a good default that at least historically applied to all the systems where the distro bootcmds were enabled. Perhaps the set of systems using the distro bootcmds has increased now so the default isn't always applicable. Boards can set $fdtfile /if/ needed because of that, but I don't think should be forced to in all cases where the default makes sense.
I really don't care whether we set fdtfile and use $fdtfile or whether we insert the filename string directly into the appropriate command variable... My point is U-Boot via its jetson-tk1_defconfig / .config knows this (or should know) better than any user. And it seemed to me that variables were not exactly used sparingly in the distro mechanism so far, so I don't see why not to populate that variable _if_ we know what its value needs to be. Do you have any real reason for being against populating fdtfile at whatever level turns out to be suitable?
I believe there is no argument that this patch will not be applied. However I am strongly rejecting your attitude that everything is there already with variables and that nothing new is needed. Something needs to be done somewhere - and we need to figure out what exactly and where for minimum impact to the release.
Thanks, Andreas