Re: [U-Boot] [PATCH 01/22] ARM: sunxi: Basic Allwinner A10/A13 (sun4i/sun5i) support

Dear Henrik Nordström,

In message 1353843450.17518.13.camel@home.hno.se you wrote:

This adds support for the Allwinner A10/A13 SoC's. Additionally board support for the dev-boards sun4i/sun5i is added.

...

+/* Return PLL5 frequency in Hz

• • Note: Assumes PLL5 reference is 24MHz clock
• */

Incorrect multiline comment style. Please fix globally.

diff --git a/include/configs/sun4i.h b/include/configs/sun4i.h new file mode 100644 index 0000000..513f618

...

+#define CONFIG_MACH_TYPE 4104

NAK.

Please use value from mach-types.h ; if needed, ask for an update.

diff --git a/include/configs/sun5i.h b/include/configs/sun5i.h new file mode 100644 index 0000000..dc84aba

...

+#define CONFIG_MACH_TYPE 4138

Ditto.

Best regards,

Wolfgang Denk