Re: [PATCH v2] ARM: imx: imx8mn-ddr4-evk: Add ethernet support

Hi Marek,

+int board_phy_config(struct phy_device *phydev) +{

• /* enable rgmii rxc skew and phy mode select to RGMII copper */
• phy_write(phydev, MDIO_DEVAD_NONE, 0x1d, 0x1f);
• phy_write(phydev, MDIO_DEVAD_NONE, 0x1e, 0x8);
• phy_write(phydev, MDIO_DEVAD_NONE, 0x1d, 0x00);
• phy_write(phydev, MDIO_DEVAD_NONE, 0x1e, 0x82ee);
• phy_write(phydev, MDIO_DEVAD_NONE, 0x1d, 0x05);
• phy_write(phydev, MDIO_DEVAD_NONE, 0x1e, 0x100);

This is a AR8031, correct? Is there a reason why you don't use the device tree binding to set RGMII voltage, and RX and tx delays?

-michael