Re: [U-Boot] [PATCH v4 4/5] cfb_console: Add support for some ANSI terminal escape codes

Hi,

On Fri, 19 Oct 2012 14:00:07 +0200 Pali Rohár pali.rohar@gmail.com wrote: ...

• When CONFIG_CFB_CONSOLE_ANSI is defined, console will have
  

• ANSI terminal support. Needed for CONFIG_CMDLINE_EDITING.
  

What do you mean here? Doesn't command line editing work without ANSI support in cfb?

• When CONFIG_CFB_CONSOLE is defined, video console is default i/o. Serial console can be forced with environment 'console=serial'.

diff --git a/drivers/video/cfb_console.c b/drivers/video/cfb_console.c index 9f7794f..3ed96d3 100644 --- a/drivers/video/cfb_console.c +++ b/drivers/video/cfb_console.c @@ -385,6 +385,11 @@ static u32 eorx, fgx, bgx; /* color pats */

static int cfb_do_flush_cache;

+static char ansi_buf[10] = { 0, };

initialisation is not needed here. I've fixed some issues with this patch, please test v5.

Thanks, Anatolij