
12 Jul
2021
12 Jul
'21
1:27 p.m.
On 7/9/21 1:53 PM, Ashok Reddy Soma wrote:
This patch set fixes below issues in zynq_sdhc driver
- Fix issues in tap delay functions where it returns uninitialized values
- Allow configuring zero tap delay values
- Split tapdelay functions to set input and output tap delay's separately.
- Fix kernel doc warnings
- Make local structures as static structures
Changes in v3:
- Updated commmit description to explain why return type int is kept
- Change "@degree" to "@degrees:" in 5/6, so revert it in 1/6 from sdhci_zynqmp_sampleclk_set_phase() and sdhci_versal_sdcardclk_set_phase()
- Updated macro's with BIT() and GENMASK() for readability
- Change "@degree" to "@degrees:" in sdhci_zynqmp_sampleclk_set_phase() and sdhci_versal_sdcardclk_set_phase() and update description with these warnings.
Changes in v2:
- Changed "@degree" to "@degrees:" in function descriptions of tap delay functions
- Removed @degree warning from commit description since it is fixed in patch 1/6.
Ashok Reddy Soma (4): mmc: zynq_sdhci: Resolve uninitialized return value mmc: zynq_sdhci: Allow configuring zero Tap values mmc: zynq_sdhci: Use Mask writes for Tap delays mmc: zynq_sdhci: Split set_tapdelay function to in and out
Michal Simek (2): mmc: zynq_sdhci: Fix kernel doc warnings mmc: zynq_sdhci: Make variables/structure static
board/xilinx/zynqmp/tap_delays.c | 73 ++++++++-------- drivers/mmc/zynq_sdhci.c | 144 ++++++++++++++++--------------- include/zynqmp_tap_delay.h | 7 +- 3 files changed, 115 insertions(+), 109 deletions(-)
Applied all. M