Hi Heiko,
-----Original Message----- From: Heiko Schocher hs@denx.de Sent: 2019年10月9日 12:37 To: U-Boot Mailing List u-boot@lists.denx.de Cc: Heiko Schocher hs@denx.de; Bin Meng bmeng.cn@gmail.com; Z.q. Hou zhiqiang.hou@nxp.com; Prabhakar X prabhakar.kushwaha@nxp.com; Z.q. Hou zhiqiang.hou@nxp.com Subject: [PATCH 0/3] pci: pcie_fsl: add support for none PCIe devices
add support for devices with compatible property: "fsl,mpc8540-pci". Unfortunately we can not change the property name, as already defined in linux.
This patch superseeds patch [1]: https://eur01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fpatch work.ozlabs.org%2Fpatch%2F1132418%2F&data=02%7C01%7CZhiqian g.Hou%40nxp.com%7Cf3882a7d460748c51be308d74c726590%7C686ea1d3 bc2b4c6fa92cd99c5c301635%7C0%7C0%7C637061926547234336&sda ta=oxZBn89GDmItT5Orj1re2ASlVWa33H1BprL1Rxg%2FPDg%3D&reserv ed=0
While working to integrate comments from Z.q. Hou to patch [1], I thought it may is the better idea, to use the already existing pcie_fsl driver and work in support for pci devices. Please comment!
If it is no good idea, I have also a v2 of [1] with the comments from Z.q. Hou worked in ready to post...
I don't think it is a good idea to add PCI controller support into PCIe controller driver, see the drivers/pci/fsl_pci_init.c, which support both PCI and PCIe controllers, but it is not readable :(. So I think it is better to separate the PCI driver into a new file just like you did in V1.
Thanks, Zhiqiang
Travis build: https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Ftravis -ci.org%2Fhsdenx%2Fu-boot-test%2Fbuilds%2F595057579&data=02%7 C01%7CZhiqiang.Hou%40nxp.com%7Cf3882a7d460748c51be308d74c72659 0%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C63706192654723 4336&sdata=3amAx0BH9zoY8MjT3GnVfmde4EJuqvYql7lO%2Fs9E15Q% 3D&reserved=0 (sheevaplug fails, but this is on discussion on list)
Heiko Schocher (3): pci: pcie_fsl: use pci_conv_size_to_32() pci: pcie_fsl: reorder addr check function pci: pcie_fsl: add support for "fsl,mpc8540-pci"
drivers/pci/pcie_fsl.c | 68 +++++++++++++++++++----------------------- drivers/pci/pcie_fsl.h | 1 + 2 files changed, 32 insertions(+), 37 deletions(-)
-- 2.21.0