Re: [U-Boot] [PATCH v5 3/4] arm: add initial support for Amlogic Meson and ODROID-C2

On Sun, May 01, 2016 at 12:56:21PM -0600, Simon Glass wrote:

...

+config ARCH_MESON

•   bool "Amlogic Meson"
  

Please add a help message describing what this is and what features it has.

Fixed in v7.

...

•   /* Reset PHY on GPIOZ_14 */
  

•   clrbits_le32(GXBB_GPIO_EN(3), BIT(14));
  

•   clrbits_le32(GXBB_GPIO_OUT(3), BIT(14));
  

•   mdelay(10);
  

•   setbits_le32(GXBB_GPIO_OUT(3), BIT(14));
  

Once you have a GPIO/pinctrl driver this could presumably be replaced.

Yeah, that's in my TODO list.

Thanks, Beniamino