Re: [U-Boot] [RFC PATCH 3/3] stdio/serial: factorize retrieve current device

Dear Jean-Christophe PLAGNIOL-VILLARD,

In message 1251034019-10787-3-git-send-email-plagnioj@jcrosoft.com you wrote:

Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD plagnioj@jcrosoft.com

Please add a commit message that exaplains what you are doing. Your Subject: line is not sufficient.

+int serial_init (void) +{

• struct stdio_dev *dev = serial_get_current_device();

• if (serial_current->start)

• return serial_current->start (serial_current);
  

• if (dev->start)

• return dev->start (dev);
  

What happens if dev == NULL ?

void serial_setbrg (void) {

• if (!(gd->flags & GD_FLG_RELOC) || !serial_current) {

• struct stdio_dev *dev = default_serial_console ();
  

• dev->setbrg (dev);
  

• return;
  

• }

• struct stdio_dev *dev = serial_get_current_device();

• serial_current->setbrg (serial_current);

• dev->setbrg (dev);

What happens if dev == NULL ?

etc.

Best regards,

Wolfgang Denk