-----Original Message----- From: Heiko Schocher [mailto:hs@denx.de] Sent: Wednesday, June 10, 2009 1:22 PM
Regarding Dirk's and Heiko's comment: A) How about board/omap3/common/power.c to drivers/power/twl4030.c
I don;t know, if this "board/omap3/common/power.c" is identical with twl4030 ... ?
The objective of power.c was to have only to have power related code for all omap3 platforms -> but currently there is only power_init_r function which is twl4030 compatible chips -> hence makes sense to break it out.
On patch C: B) introduce a new header in include/twl4030.h from Tom's patch Remove drivers/i2c/twl4030_i2c.c from the patch instead add: #define TWLL4030_READ_U8(MODULE, VAL,REG)\ i2c_read((MODULE), (REG), 1, (VAL), 1) #define TWLL4030_WRITE_U8(MODULE, VAL,REG)\ i2c_read((MODULE), (REG), 1, (VAL), 1) to include/twl4030.h in the patch.
Maybe an option ... thats why I think it is no i2c driver ...
C) on [PATCH 3/4] ZOOM2 Add power reset button The change should go to corresponding board file -> for zoom1 or zoom2.
or in "drivers/power/twl4030.c", if it is for all zoom* boards identical.
Yes - it can belong there I agree.
Regards, Nishanth Menon