
Hi,
1. Does it make sense at all to define CONFIG_RMII without defining CONFIG_MII? The question is meant not really theoretical as in what meaning RMII has, rather how the macro CONFIG_RMII is supposed to be used? For example, tests like
#if defined(CONFIG_MII) && defined(CONFIG_RMII)
isn't checking for CONFIG_MII redundant?
2. cpu/at32ap/at32ap7000/gpio.c also tests CONFIG_RMII. at32ap is an AVR32 CPU and this macro is only defined in a few MPC8XX configurations, so, this test doesn't seem to make much sense in the current tree.
3. drivers/qe/uec_phy.c tests CONFIG_RMII_MODE, which doesn't occur anywhere else in the tree. The driver is enabled in some MPC85xx and MPC83xx configs.
4. drivers/macb.c tests for "RMII or MII mode" by jest checking
#ifdef CONFIG_RMII ... #else ... #endif
i.e., not for
#elif defined CONFIG_MII
This driver is only enabled in include/configs/atstk1002.h, which is also an AVR32 config, and it neither defines MII nor RMII.
Thanks Guennadi --- Guennadi Liakhovetski, Ph.D.
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: office@denx.de