10 Jun
2013
10 Jun
'13
9:02 a.m.
On 06/06/2013 10:06 PM, Robert Winkler wrote:
One other unrelated question for Nikita from his splash prepare patch. Why did you use gd->fb_base when the global lcd_base is used elsewhere in the function and lcd.c in general. It seems inconsistent.
1094 if (splash_screen_prepare()) 1095 return (void *)gd->fb_base;
I really don't remember anymore, but it was probably a refactoring oversight or something similarly insignificant. The two are equivalent, so feel free to change it to lcd_base to make it more consistent with the rest of the code.
-- Regards, Igor.
Please advise,
Robert
--
Regards,
Nikita.