Hi Wolfgang Denk,
On 01/29/2013 03:52 PM, Wolfgang Denk wrote:
Dear Nikita Kiryanov,
In message 1359463349-11649-3-git-send-email-nikita@compulab.co.il you wrote:
Currently the value of gfx_format is hardcoded into omap3_dss_panel_config(). Make it a field in struct panel_config, and update existing structs to set this field to the value that was originally hard coded.
It is not exactly clear to me what exactly this is needed for? Are you just adding dead code? if not, then please explain this in the commit message.
Currently if you want to use a gfx format other than what omap3_dss_panel_config() sets, you have to change it manually. It was suggested in the review of V1 that it would be better if this value could simply be passed to omap3_dss_panel_config() so that there wouldn't be a need for adjustments.
I'll try to rephrase the commit message to explain the benefits of this.
Best regards,
Wolfgang Denk