Hi Andy,
On Tue, May 21, 2019 at 2:45 PM Andy Tang andy.tang@nxp.com wrote:
Hi Bin,
Thanks for your review. Please see my comments below.
-----Original Message----- From: Bin Meng bmeng.cn@gmail.com Sent: 2019年5月17日 14:32 To: Andy Tang andy.tang@nxp.com Cc: Simon Glass sjg@chromium.org; Tom Rini trini@konsulko.com; Prabhakar Kushwaha prabhakar.kushwaha@nxp.com; Sudhanshu Gupta sudhanshu.gupta@nxp.com; U-Boot Mailing List u-boot@lists.denx.de; Ran Wang ran.wang_1@nxp.com; Bhaskar Upadhaya bhaskar.upadhaya@nxp.com Subject: Re: [EXT] Re: [U-Boot] [PATCH 1/3 v3] armv8: ls1028a: Add NXP LS1028A SoC support
Caution: EXT Email
Hi Andy,
On Fri, May 17, 2019 at 11:23 AM Andy Tang andy.tang@nxp.com wrote:
Hi Bin,
-----Original Message----- From: Bin Meng bmeng.cn@gmail.com Sent: 2019年5月16日 20:10 To: Andy Tang andy.tang@nxp.com; Simon Glass
Tom Rini trini@konsulko.com Cc: Prabhakar Kushwaha prabhakar.kushwaha@nxp.com; Sudhanshu
Gupta
sudhanshu.gupta@nxp.com; U-Boot Mailing List u-boot@lists.denx.de; Ran Wang ran.wang_1@nxp.com; Bhaskar Upadhaya bhaskar.upadhaya@nxp.com Subject: [EXT] Re: [U-Boot] [PATCH 1/3 v3] armv8: ls1028a: Add NXP LS1028A SoC support
Hi,
On Wed, Apr 10, 2019 at 4:50 PM Yuantian Tang andy.tang@nxp.com wrote:
Ls1028a Soc is based on Layerscape Chassis Generation 3.2 architecture with features: 2 ARM v8 Cortex-A72 cores, CCI400, SEC, DDR3L/4, LCD, GPU, TSN ENETC, 2 USB 3.0, 2 eSDHC, 2 FlexCAN, 2 SPI, SATA, 8 I2C controllers, 6 LPUARTs, GPIO, SAI, qDMA, eDMA, GIC, TMU etc.
Signed-off-by: Sudhanshu Gupta sudhanshu.gupta@nxp.com Signed-off-by: Rai Harninder harninder.rai@nxp.com Signed-off-by: Rajesh Bhagat rajesh.bhagat@nxp.com Signed-off-by: Bhaskar Upadhaya Bhaskar.Upadhaya@nxp.com Signed-off-by: Tang Yuantian andy.tang@nxp.com
v3: -- fix some issues arch/arm/cpu/armv8/fsl-layerscape/Kconfig | 39 ++- arch/arm/cpu/armv8/fsl-layerscape/Makefile | 4 + arch/arm/cpu/armv8/fsl-layerscape/cpu.c | 3 + arch/arm/cpu/armv8/fsl-layerscape/doc/README.soc | 51 ++++ arch/arm/cpu/armv8/fsl-layerscape/ls1028a_serdes.c | 73 ++++++ arch/arm/dts/fsl-ls1028a.dtsi | 280
+++++++++++++++++++++
arch/arm/include/asm/arch-fsl-layerscape/config.h | 61 +++++ .../include/asm/arch-fsl-layerscape/immap_lsch3.h | 9 + arch/arm/include/asm/arch-fsl-layerscape/soc.h | 1 + .../asm/arch-fsl-layerscape/stream_id_lsch3.h | 2 +- 10 files changed, 521 insertions(+), 2 deletions(-) create mode 100644 arch/arm/cpu/armv8/fsl-layerscape/ls1028a_serdes.c create mode 100644 arch/arm/dts/fsl-ls1028a.dtsi
I really would like to see complete DM driver support on this new
platform.
Please consider converting appropriate codes to driver model. If there is no proper uclass model, please propose one and discuss it on the list. I see the existing NXP PowerPC support is stuck in such a situation that lots of codes are still non-DM and we are getting close to the DM deadline. I don't want to see such happens again in the
NXP ARM support.
Could you please be more specific which part of code is non-DM based? I checked it and didn't find where is non-DM. Thanks for your review.
For example, the "config ARCH_LS1028A" selects the following I2C components:
select SYS_I2C_MXCselect SYS_I2C_MXC_I2C1select SYS_I2C_MXC_I2C2select SYS_I2C_MXC_I2C3select SYS_I2C_MXC_I2C4select SYS_I2C_MXC_I2C5select SYS_I2C_MXC_I2C6select SYS_I2C_MXC_I2C7select SYS_I2C_MXC_I2C8These I2C# macros look to me this is not DM based. For DM such stuff is determined from the DT automatically.
Agree. Our I2C IP owner is working on it and will change all I2C driver to DM based.
Great.
For ls1028a_serdes.c, we probably need create serdes uclass driver for it.
We don't have serdes dts node in both uboot and kernel. So I think we can leave it as it is.
I see. Then let's keep it as it is.
For arch/arm/cpu/armv8/fsl-layerscape/cpu.c, can we create a CPU driver for it? I see lots of CONFIG_XXX_BASE and CONFIG_XXX_SIZE in this file that come from arch/arm/include/asm/arch-fsl-layerscape/cpu.h? Can't we get such in DT?
Agree. But this affects all our platforms and need big efforts. Many components are involved in it. We will convert it step by step.
Sounds you already have a plan, which is good!
Regards, Bin