Re: [U-Boot] [PATCH 5/5] aspeed: Activate ethernet devices on the ast2500 Eval Board

On 09/11/2018 02:55 AM, Joel Stanley wrote:

On Mon, 10 Sep 2018 at 23:56, Cédric Le Goater clg@kaod.org wrote:

...

diff --git a/arch/arm/dts/ast2500-evb.dts b/arch/arm/dts/ast2500-evb.dts index 609678ff7989..1bd224dacf78 100644 --- a/arch/arm/dts/ast2500-evb.dts +++ b/arch/arm/dts/ast2500-evb.dts

...

+&mac0 {

•   status = "okay";
  

•   phy-mode = "rgmii";
  

•   pinctrl-names = "default";
  

•   pinctrl-0 = <&pinctrl_mac1link_default &pinctrl_mdio1_default>;
  

+};

+&mac1 {

•   status = "disabled";
  

Is there a reason you don't have both enabled?

none. we should enable both. I initially disabled mac1 to check how the scu bits where being set by the pinctrl driver in U-Boot.

On the eval board I use I can use either.

yes.

Thanks,

C.