26 Sep
2011
26 Sep
'11
8:15 p.m.
On Monday, September 26, 2011 13:58:59 Wolfgang Denk wrote:
Mike Frysinger wrote:
...here you change a compile time error check into a runtim error.
no, it'll still be a build time error as IH_ARCH_DEFAULT will be undefined
it just might not be as clean an error ... gcc will complain about IH_ARCH_DEFAULT not being defined rather than a helpful "Unknown CPU type"
Should it not be trivial to add a
#ifndef IH_ARCH_DEFAULT # error Unknown CPU type: IH_ARCH_DEFAULT not set #endif
or similar to include/image.h ?
it'd certainly be easy to do. i just pointed out that you still get a build failure after my change :). so if you want the #error, i'll resend w/it. -mike