Dear Wolfgang Denk,
--- a/common/cmd_nvedit.c +++ b/common/cmd_nvedit.c @@ -125,7 +125,7 @@ static int env_print(char *name) }
/* print whole list */
- len = hexport_r(&env_htab, '\n',&res, 0);
len = hexport_r(&env_htab, '\n',&res, 0, 0, NULL);
if (len> 0) { puts(res);
Here you extended the function signature by adding 2 new arguments and therefore you had to touch 12 existing function calls so to add the default values for the new args.
In my previous patches, I had renamed the sibling himport_r() function to himport_ex() with the 2 extra args and reimplemented himport_r() as a wrapper, so to maintain compatibility with the existing code. Just to realize now that, after some reworking, there is only one function call to the original himport_r() left. I'm going to get rid of this renaming.
I mean: completely opposite approaches... funny, huh?
Best, Gerlando Falauto