Hi Miquel,
On 2020/3/17 下午11:32, Miquel Raynal wrote:
It seems that this line was added by mistake as right before it there is another function printing debug info already, so this line is pretty much useless, drop it.
This line is not add by mistake, if you have more experience on rockchip dram init binaries,
you can see this 'out' in most of them, which means the dram init has been done.
This is useless in logical for it just after dram info print for px30 dram driver, so it's OK to drop.
Thanks,
- Kever
Fixes: 39edfaa758a ("ram: px30: add sdram driver") Signed-off-by: Miquel Raynal miquel.raynal@bootlin.com
drivers/ram/rockchip/sdram_px30.c | 1 - 1 file changed, 1 deletion(-)
diff --git a/drivers/ram/rockchip/sdram_px30.c b/drivers/ram/rockchip/sdram_px30.c index ee657573111..a07f05ded07 100644 --- a/drivers/ram/rockchip/sdram_px30.c +++ b/drivers/ram/rockchip/sdram_px30.c @@ -714,7 +714,6 @@ int sdram_init(void)
sdram_print_ddr_info(&sdram_params->ch.cap_info, &sdram_params->base);
- printascii("out\n"); return ret; error: return (-1);