On 01/22/2014 08:44 PM, Gerhard Sittig wrote:
On Wed, Jan 22, 2014 at 12:02 +0100, Michal Simek wrote:
--- /dev/null +++ b/common/cmd_clk.c @@ -0,0 +1,51 @@ +/*
- Copyright (C) 2013 Xilinx, Inc.
- SPDX-License-Identifier: GPL-2.0+
- */
+#include <common.h> +#include <command.h> +#include <clk.h>
+int __weak soc_clk_dump(void) +{
- puts("Not implemented\n");
- return 1;
+}
+static int do_clk_dump(cmd_tbl_t *cmdtp, int flag, int argc,
char *const argv[])+{
- return soc_clk_dump();
+}
Is there a specific reason to not pass on the remaining (not yet consumed) command line arguments? Future implementations may want to take a clock item's name, or a clock group's name, or options related to the format or verbosity of the dump, et al.
Only one reason is that I don't need it for my zynq implementation. If this is necessary there is no problem to pass them because it is internal API. Also I prefer to pass just arguments which I need.
I have looked at i.MXes cases and they do in general what my zynq implementation. They can just include clk.h and change do_mx6_showclocks to soc_clk_dump.
Thanks, Michal