On Sat, Aug 18, 2012 at 10:18 AM, Stefano Babic sbabic@denx.de wrote:
On 17/08/2012 20:16, Matt Sealey wrote:
Essentially now we can share code with the MX6 boards, reducing redundant pin definitions across boards and lengthy configuration of external pads on the i.MX51.
Signed-off-by: Matt Sealey matt@genesi-usa.com
Hi Matt,
arch/arm/include/asm/arch-mx5/iomux-mx51.h | 144 ++++++++++++++++++++++++++++ 1 file changed, 144 insertions(+) create mode 100644 arch/arm/include/asm/arch-mx5/iomux-mx51.h
As far as I can see iomux-mx51.h is coming from the linux kernel. Then please add in the commit message information about which version of the kernel you borrow this code, better add the kernel commit-id. This allows to have a track where the code is coming from.
I will, for now it's the top of Linus' tree, but this code is going to get removed from the Linux kernel soon, so I understand, we need to figure out where it will last forever (probably linux-stable@3.5) so we can always reference it.
I do like we add a second identical defeine why we discover an issue in another part of code. I know for experience that code introduced this the goal to fix it later will never be fixed. So let's see if we can jut do the right thing.
I do not think imx-common/iomux-v3.h is the right place. What has the pinmux with gpio to do? This is also wrong....it is GPIO related, it should go into gpio.h.
That's true. I did not want to mess the patchset up with boards I cannot test though, and I don't like committing code I didn't test (mx3 gpio etc.) even if the docs say as much as it's identical. I see you already fixed that though.
I'll rebase on Monday and submit something new... see below, though..
+#endif /* __IOMUX_MX51_H__ */
Ok, good, this is the same as in kernel.
Right. This all came from a discussion with Troy and Eric at BoundaryDevices about i2c multi-bus support, they sent us a file with MX6 support and a hack for MX5 support to go with it; it didn't work and I figured it'd be a good thing to complete. Troy suggested not copying the Linux file verbatim (after all, why include camera bus pinmux when U-Boot won't support a camera bus?) and just include the pins we wanted. So, this is what I did, but right now I'm going to find a nice stable commit and tree where this file exists (the one I copy pasted the pins out of..).
I just noticed that the imx-common/iomux-v3.h is out of date re the latest kernel too (some bits have moved as MX6 needs extra space to store some setting) so I'll patch that in as well.
I think we need to make a small discussion point here (new thread?) about what needs to be done and what has been done, since if this isn't a tree and just patches on a mailing list or in a patchwork it's infuriatingly hard to track what is going on and who patched what and what to base against. I may have to wait until something like your gpio.h changes hit the u-boot-imx tree..