Hi Simon,
On Wed, Nov 20, 2019 at 1:53 AM Simon Glass sjg@chromium.org wrote:
Hi Bin,
On Tue, 19 Nov 2019 at 05:53, Bin Meng bmeng.cn@gmail.com wrote:
Hi Simon,
On Mon, Oct 21, 2019 at 11:40 AM Simon Glass sjg@chromium.org wrote:
Reduce the size of the probe function but putting this code into its own function.
It's unclear to me why this brings any benefit? The size of the probe function indeed is reduced, but whole file size does not change, no?
It's just that it gives the code a name and groups it in a function. It is normally better to have shorter functions and this one seemed to be getting a bit long and unfocussed.
OK, I think I misunderstood it. I thought you wanted to reduce the code size for TPL when I saw the commit message, but it didn't reduce code size at all.
Reviewed-by: Bin Meng bmeng.cn@gmail.com
Regards, Bin