
29 Aug
2010
29 Aug
'10
1:17 a.m.
On Saturday, August 28, 2010 17:48:39 Mike Frysinger wrote:
/* Make sure the ID was jedec extended */
j = flashes[i].shift - 1;
while (j >= 0 && idcode[j] == 0x7f)
continue;
thinko ... this loops forever. the tested fix: j = flashes[i].shift; while (--j >= 0) if (idcode[j] != 0x7f) break;
this whole change increases code size a bit (20 - 60 bytes on Blackfin depending on how many flashes are supported), but it makes management easier and allows for arbitrarily long manufacturers ids. so i think it's worth it. -mike