Re: [U-Boot] [PATCH] Crash in env_relocate_spec() of env_mmc.c

Steve Sakoman wrote:

On Fri, Oct 8, 2010 at 1:03 AM, Stefano Babic sbabic@denx.de wrote:

...

mmc_initialize is not called at the startup if the relocation takes place and the environment is stored into a MMC card.

Hallo Steve,

I think it might make more sense to put the MMC ifdef after the onenand code so that it doesn't split the nand/onenand grouping. Otherwise it matches what I did.

Yes, it makes more sens - and I do not see any problem to move it

This is a void function and shouldn't have a return value. I fixed this in my version.

Agree.

...

   gd->env_valid = 1;

I removed this in my version, probably an error to do that though :-)

Or probably not...env_valid should signalize if the checksum is correct, and now the checksum is verified by the env_import function, as I have understood.

I previously submitted a patch to fix this and Wolfgang sent an email saying that it had been applied.

Ah, ok, I have missed it ;-)

I'll revise my patch to add the missing gd->env_valid = 1; and re-test.

Ok, thanks

Stefano