Re: [PATCH v5 2/3] mtd: spi-nor-core: Adding different type of command extension in Soft Reset

Hi Tudor

On 11/18/21 12:13 PM, JaimeLiao wrote:

...

EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe

Power-on-Reset is a method to restore flash back to 1S-1S-1S mode from 8D-8D-8D in the begging of probe.

Command extension type is not standardized across flash vendors in DTR mode.

For suiting different vendor flash devices, adding a flag to seperate types for soft reset on boot.

Signed-off-by: JaimeLiao jaimeliao.tw@gmail.com

drivers/mtd/spi/Kconfig | 7 +++++++ drivers/mtd/spi/spi-nor-core.c | 7 ++++++- 2 files changed, 13 insertions(+), 1 deletion(-)

diff --git a/drivers/mtd/spi/Kconfig b/drivers/mtd/spi/Kconfig index 1b2ef37e92..9b7d195770 100644 --- a/drivers/mtd/spi/Kconfig +++ b/drivers/mtd/spi/Kconfig @@ -97,6 +97,13 @@ config SPI_FLASH_SMART_HWCAPS can support a type of operation in a much more refined way compared to using flags like SPI_RX_DUAL, SPI_TX_QUAD, etc.

+config SPI_NOR_BOOT_SOFT_RESET_EXT_INVERT

There will be many combinations of reset types and cmd_ext types, better to introduce a way to select the reset type and then to select the cmd_ext type so that we avoid introducing so many configs/dt props.

I think Pratyush is working to fix this, would you sync with him?

Sure, this configuration is according Pratyush suggestion.

Check the discussion at https://lore.kernel.org/all/20211103234950.202289-4-tudor.ambarus@microchip....

Cheers, ta

...

•   bool "Command extension type is INVERT for Software Reset on boot"
  

•   default n
  

•   help
  

•    Because of SFDP information can not be get before boot.
  

•    So define command extension type is INVERT when Software Reset on boot only.
  

config SPI_FLASH_SOFT_RESET bool "Software Reset support for SPI NOR flashes" default n diff --git a/drivers/mtd/spi/spi-nor-core.c b/drivers/mtd/spi/spi-nor-core.c index 0a6550984b..2b6947cefc 100644 --- a/drivers/mtd/spi/spi-nor-core.c +++ b/drivers/mtd/spi/spi-nor-core.c @@ -3661,7 +3661,12 @@ static int spi_nor_soft_reset(struct spi_nor *nor) enum spi_nor_cmd_ext ext;

    ext = nor->cmd_ext_type;

•   nor->cmd_ext_type = SPI_NOR_EXT_REPEAT;
  

•   if (nor->cmd_ext_type == SPI_NOR_EXT_NONE) {
  

•           nor->cmd_ext_type = SPI_NOR_EXT_REPEAT;
  

+#if CONFIG_IS_ENABLED(SPI_NOR_BOOT_SOFT_RESET_EXT_INVERT)

•           nor->cmd_ext_type = SPI_NOR_EXT_INVERT;
  

+#endif /* SPI_NOR_BOOT_SOFT_RESET_EXT_INVERT */

•   }
  
    op = (struct spi_mem_op)SPI_MEM_OP(SPI_MEM_OP_CMD(SPINOR_OP_SRSTEN, 0),
                    SPI_MEM_OP_NO_DUMMY,
  

-- 2.17.1