28 Dec
2021
28 Dec
'21
9:34 a.m.
Hi Ovidiu,
On Sat, 25 Dec 2021 at 12:57, Ovidiu Panait ovidiu.panait@windriver.com wrote:
bedbug/types.h is included to provide bedbug_init() declaration, which is an empty stub that is only called from the common init sequence. In order to get rid of this dependency and the associated #ifdef:
- move the bedbug_init() declaration from include/bedbug/type.h to include/init.h
- provide a weak stub for bedbug_init() in board_r.c, so each CPU can provide its own implementation, as explained in the function comment
Signed-off-by: Ovidiu Panait ovidiu.panait@windriver.com
cmd/bedbug.c | 14 -------------- common/board_r.c | 10 ++++++---- include/bedbug/type.h | 1 - include/init.h | 11 +++++++++++ 4 files changed, 17 insertions(+), 19 deletions(-)
Reviewed-by: Simon Glass sjg@chromium.org
But I wonder if we can just remove this feature, since no board defines either CONFIG_CMD_BEDBUG or a real bedbug_init() ?