On 26/04/19 4:56 AM, Simon Glass wrote:
Hi Bin,
I find that 'sf test 0 1000' does not work anymore since this commit:
c4e8862308 mtd: spi: Switch to new SPI NOR framework
Have you seen any problems? This seems to prevent proper SPI flash writing (not sure about reading).
Sorry for that.
Could you see if this patch[1] fixes the write issue?
Also, it seemed to increase code size on samus by >2KB.
Above commit ports Linux SPI NOR framework in order to support 4 byte addressing SPI NOR opcodes and spi_mem_ops (to support both SPI NOR and SPI NAND flashes using single SPI driver) therefore there is code size increase.
But, I did provide SPL_SPI_FLASH_TINY which can be enabled to reduce binary size on resource constraint board. Note that SPL_SPI_FLASH_TINY only supports reading from flash and does not support write (Since SPL just needs to support reading next stage image)
[1] http://patchwork.ozlabs.org/patch/1090121/