Re: [PATCH] video: stm32: stm32_ltdc: fix data enable polarity

HI Yannick

On 4/6/22 10:37, Yannick FERTRE wrote:

Wrong DISPLAY_FLAGS used to set the data enable polarity.

Signed-off-by: Yannick FERTRE yannick.fertre@foss.st.com

drivers/video/stm32/stm32_ltdc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/video/stm32/stm32_ltdc.c b/drivers/video/stm32/stm32_ltdc.c index e741e74739..9269d4bfb4 100644 --- a/drivers/video/stm32/stm32_ltdc.c +++ b/drivers/video/stm32/stm32_ltdc.c @@ -255,7 +255,7 @@ static void stm32_ltdc_set_mode(struct stm32_ltdc_priv *priv, val |= GCR_HSPOL; if (timings->flags & DISPLAY_FLAGS_VSYNC_HIGH) val |= GCR_VSPOL;

• if (timings->flags & DISPLAY_FLAGS_DE_HIGH)

• if (timings->flags & DISPLAY_FLAGS_DE_LOW) val |= GCR_DEPOL; if (timings->flags & DISPLAY_FLAGS_PIXDATA_NEGEDGE) val |= GCR_PCPOL;

Reviewed-by: Patrice Chotard patrice.chotard@foss.st.com

Thanks Patrice