Re: [U-Boot] [PATCH v2 03/11] efi_loader: return efi_status_t from efi_net_register

Hi,

On 15 February 2018 at 00:31, Heinrich Schuchardt xypron.glpk@gmx.de wrote:

Consistently return status codes form efi_net_register().

Signed-off-by: Heinrich Schuchardt xypron.glpk@gmx.de

v2 new patch

---

include/efi_loader.h | 2 +- lib/efi_loader/efi_net.c | 24 +++++++++++++----------- 2 files changed, 14 insertions(+), 12 deletions(-)

Reviewed-by: Simon Glass sjg@chromium.org

I have a similar comment to the previous patch re using printf() to report errors. Ideally the error should be returned to the caller (and perhaps logged with log() or debug()).

Regards, Simon