Re: [U-Boot] [PATCH 5/5] Warn when the machine ID isn't passed to an ARM kernel and u-boot is compiled in debug mode. The kernel cannot boot without it.

On 07/05/11 13:04, Wolfgang Denk wrote:

Dear Igor Grinberg,

In message 4E12BF5D.6080307@compulab.co.il you wrote:

...

...

•        debug("\nWarning: machid not set! Linux will not finish booting.\n\n");
  

• }

+#endif

Is there a reason to close this in ifdef DEBUG? and also use debug()? I would print this in any case, because machid must be set for Linux to boot properly. This message will not hurt anyone (just add ~50 bytes, this is not an spl code) and if someone hacks Linux to boot in any case (without checking the machid), then he can also hack U-Boot and remove the message (if it bothers him).

I think "Warning: machid not set" should be sufficient.

Agreed!

Note: we should't print excessive newlines. No \n at the begin of the string, only one at the end.

Best regards,

Wolfgang Denk