Graeme Russ graeme.russ@gmail.com wrote on 20/10/2009 23:44:14:
On Wed, Oct 21, 2009 at 1:35 AM, Joakim Tjernlund joakim.tjernlund@transmode.se wrote:
In preperation for full relocation
Signed-off-by: Graeme Russ graeme.russ@gmail.com
cpu/i386/Makefile | 2 +- cpu/i386/cpu.c | 1 - cpu/i386/exceptions.c | 229 --------------------- cpu/i386/interrupts.c | 431 ++++++++++++++++++++++++++++++++++++++-- include/asm-i386/interrupt.h | 27 --- include/asm-i386/u-boot-i386.h | 3 - lib_i386/interrupts.c | 4 +- lib_i386/pcat_interrupts.c | 33 --- 8 files changed, 420 insertions(+), 310 deletions(-) delete mode 100644 cpu/i386/exceptions.c
Don't know much about x86, but should not these new asm symbools be .hidden and .type <fun>, @function ?
Yes
+#define DECLARE_INTERRUPT(x) \
- ".globl irq_"#x"\n" \
- "irq_"#x":\n" \
- "pushl %ebp\n" \
- "movl %esp,%ebp\n" \
- "pusha\n" \
- "pushl $"#x"\n" \
- "jmp irq_common_entry\n"
Done in patch 8
Ah, sorry for the noise.
+asm(".globl irq_common_entry\n" \
- "irq_common_entry:\n" \
- "pushl $0\n" \
- "pushl $0\n" \
- "call irq_llsr\n" \
- "popl %eax\n" \
- "popl %eax\n" \
I missed this one - I will respin patch 8 after any further comments have been made
OK, at least something good came from this mail.
Jocke