On 11/12/2016 12:47 AM, Stefan Agner wrote:
Hi Marek,
Hi!
On 11.11.2016 14:33, Marek Vasut wrote:
On 11/11/2016 11:18 PM, Stefan Agner wrote:
From: Stefan Agner stefan.agner@toradex.com
This cleans up the SPL USB Gadget Kconfig and Makfile a bit. The first two patches are actual fixes and we might consider to add them for the v2016.11 release. The third one adds a new config option for cleaner structure. I plan to add another USB function with SPL support which is the reason I looked into this...
Build tested mainly with dra7xx_evm_defconfig (for CONFIG_SPL_DFU_SUPPORT) and am335x_evm_usbspl_defconfig (for CONFIG_SPL_USBETH_SUPPORT)
I am sorry, it seems I can't handle patman on friday afternoon :-) Will try to do better next time.
No problem
There are multiple issues:
- Would be nice if the cover letter had real Subject
- It's build tested on two boards, people test such disruptive changes
using buildman on at least a few architectures (arm/mips/ppc are the usual suspects)
The changes are not that disruptive as they might seem, but sure, one never knows... Note that the two boards were carefully selected: They are the _only_ ones which actually select the changed configuration options....
Actually dra7xx_evm_defconfig does not even select CONFIG_SPL_DFU_SUPPORT, but git log/mailing list history tells me that this is the board where that configuration has been developed with...
OK, got it.
- It is not acceptable as fixes for 2016.11 because it doesn't seems it
was ever boot tested
I don't have any of the two boards :-(
Lukasz, if you could help me out here on the dra7xx_evm I would be glad.
So how did these fixes come to be ?
- Please send To: U-Boot list
- Please cull the CC list, it's horrible
Ok, I thought that was desirable, since it is the default when using patman...
Having 20+ people on CC is not really so anymore ;-)