15 Jan
2017
15 Jan
'17
7:32 p.m.
On Wed, Jan 11, 2017 at 04:51:53PM +0100, Gary Bisson wrote:
Since commit aa6ab905b2, sata_initialize returns -1 if init_sata or scan_sata fails. But this return value becomes the do_sata return value which is equivalent to CMD_RET_USAGE.
In case one issues 'sata init' and that the hardware fails to initialize, there's no need to display the command usage. Instead the command shoud just return the CMD_RET_FAILURE value.
Fixes: aa6ab905b2 (sata: fix sata command can not being executed bug)
Signed-off-by: Gary Bisson gary.bisson@boundarydevices.com Reviewed-by: Eric Nelson eric@nelint.com Reviewed-by: Simon Glass sjg@chromium.org
Applied to u-boot/master, thanks!
--
Tom