Dear Niklaus Giger,
In message 1253719369-26565-2-git-send-email-niklaus.giger@netstal.com you wrote:
- CONFIG_SYS_BOOTMAPSZ for 16 instead of 8 MB, moved to common
- baudrate back to 9600 for backward compatibility
- HCU4: CONFIG_SYS_ICACHE_SACR_VALUE defined
- CONFIG_VXWORKS_PREBOOT for HCU4 and MCU25
- HCU5: Add CPU and OCM POST
...
-#define CONFIG_DDR_ECC 1 /* enable ECC */ +/* warum gibt es Fehler mit #undef CONFIG_DDR_ECC (Hub) */ +#define CONFIG_DDR_ECC +#undef DISABLE_DDR_ECC_AFTER_POST /* disable ECC after POST tests */
I recommend to use comments in one language only.
...
+/* defining CONFIG_4xx_DCACHE leads to erros in memory_extended_tests */ +#undef CONFIG_WATCHDOG +/* Watchdog cannot be enabled, as it would be still enabled booting vxWorks */ +#undef CONFIG_4xx_DCACHE
It seems comments and code are mixed pretty randomly. I guess this is not intentional?
...
-#define CONFIG_SYS_BOOTMAPSZ (8 << 20) /* Initial Memory map for Linux */ +#define CONFIG_SYS_BOOTMAPSZ (16 << 20) /* Initial Memory map for Linux */ +#define CONFIG_SYS_BOOTM_LEN (16 << 20) /* Increase max gunzip size */
Hm.. "Increase" is more suitable for the change log, but as a comment? Assume you read this in two years from now. What is being increased?
Best regards,
Wolfgang Denk
-- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd@denx.de I have the simplest tastes. I am always satisfied with the best. -- Oscar Wilde